Node and Vagrant evolves#204
Closed
camlafit wants to merge 4 commits into
Closed
Node and Vagrant evolves#204camlafit wants to merge 4 commits into
camlafit wants to merge 4 commits into
Conversation
* As we have yet git clone repo to run vagrant, we can use un synced repository
* Move to last ubuntu LTS ** Should solve lwip problem compilation YellowLabTools#187 * Solve others warning about node cascade requirement
gmetais
reviewed
Dec 29, 2016
| "lwip": "0.0.8", | ||
| "md5": "2.1.0", | ||
| "meow": "3.7.0", | ||
| "nan": ">=2", |
Collaborator
There was a problem hiding this comment.
How useful is the nan module? I don't get what its job is.
| "is-woff": "1.0.3", | ||
| "is-woff2": "1.0.0", | ||
| "lwip": "0.0.9", | ||
| "lwip": "0.0.8", |
Collaborator
There was a problem hiding this comment.
Why downgrading lwip from 0.0.9 to 0.0.8?
gmetais
reviewed
Dec 29, 2016
| "grunt-replace": "~1.0.1", | ||
| "grunt-usemin": "~3.1.1", | ||
| "grunt-webfont": "~1.4.0", | ||
| "grunt-webfont2": "~1.0.0", |
Collaborator
There was a problem hiding this comment.
And why switching to grunt-webfont2? The grunt-webfont project seems to be maintained.
Collaborator
|
Hi @camlafit, Thanks a lot for this pull request 👍. I've just commited some of your changes into the develop branch and it will make it's way to the master branch soon: I'm keeping this pull request open, cause I'm still interested by your other changes if they can fix something I didn't see! |
Contributor
Author
|
Hi
I saw an another problem with jenkins check. Node version are different. I
presume we can correct this also. I'm in late about this.
I hope provide an add soon.
|
Contributor
Author
|
About package.json is just changed to follow warning get by npm install.
tree requirement plugins is a bit complex , de mémoire, nan is
required by a third or fourth level plugin
|
Collaborator
|
Thanks @camlafit, I'll integrate this directly in YLT v2's branch! |
Contributor
Author
|
Hello Sorry it's again in WIP. I've tried to move to more recent boxes, is not yet ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits solves some problem to run a Vagrant instance
Second part is an upgrade node environment to reduce some Error and Warning during installation