Add early exit clauses to files with procedural code#790
Merged
felixarntz merged 1 commit intoJul 25, 2023
trunkWordPress/performance:trunkfrom
fix/procedural-files-early-exitWordPress/performance:fix/procedural-files-early-exitCopy head branch name to clipboard
Merged
Add early exit clauses to files with procedural code#790felixarntz merged 1 commit intotrunkWordPress/performance:trunkfrom fix/procedural-files-early-exitWordPress/performance:fix/procedural-files-early-exitCopy head branch name to clipboard
felixarntz merged 1 commit into
trunkWordPress/performance:trunkfrom
fix/procedural-files-early-exitWordPress/performance:fix/procedural-files-early-exitCopy head branch name to clipboard
Conversation
felixarntz
requested review from
JustinyAhin,
adamsilverstein,
kirtangajjar,
manuelRod,
mitogh,
pbearne and
spacedmonkey
as code owners
July 25, 2023 15:14
joemcgill
approved these changes
Jul 25, 2023
swissspidy
approved these changes
Jul 25, 2023
mukeshpanchal27
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This was flagged during plugin review of the "Dominant Color Images" submission. Any files with procedural code should have an early exit condition. Most typically the one based on whether
! defined( 'ABSPATH' ), but another relevant constant can used as well. For example, in the files where we already check for a Performance Lab specific constant on top of the file, we don't have to add to or update those files.Keep in mind that this is only required for files with procedural code, i.e. not files that only contain a class or similar construct.
There are varying opinions on this approach, but given it's requested by the plugin review team and is not a big deal to add, let's follow the pattern.
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.