Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix errors detected by Plugin Checker#788

Merged
felixarntz merged 1 commit into
trunkWordPress/performance:trunkfrom
fix/787-phpcs-issuesWordPress/performance:fix/787-phpcs-issuesCopy head branch name to clipboard
Jul 21, 2023
Merged

Fix errors detected by Plugin Checker#788
felixarntz merged 1 commit into
trunkWordPress/performance:trunkfrom
fix/787-phpcs-issuesWordPress/performance:fix/787-phpcs-issuesCopy head branch name to clipboard

Conversation

@mukeshpanchal27

@mukeshpanchal27 mukeshpanchal27 commented Jul 21, 2023

Copy link
Copy Markdown
Member

Summary

Fixes #787

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Jul 21, 2023
@mukeshpanchal27 mukeshpanchal27 added this to the PL Plugin 2.6.0 milestone Jul 21, 2023
@mukeshpanchal27 mukeshpanchal27 self-assigned this Jul 21, 2023
@mukeshpanchal27
mukeshpanchal27 marked this pull request as ready for review July 21, 2023 08:42
@felixarntz felixarntz changed the title Fix Errors Detected by Plugin Checker Fix errors detected by Plugin Checker Jul 21, 2023

@felixarntz felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, LGTM!

@felixarntz
felixarntz merged commit b7365ec into trunk Jul 21, 2023
@felixarntz
felixarntz deleted the fix/787-phpcs-issues branch July 21, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Bug An existing feature is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors in Performance Lab Plugin Detected by Plugin Checker

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.