Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add wp-total metric to default Server-Timing metrics#669

Merged
felixarntz merged 1 commit into
trunkWordPress/performance:trunkfrom
add/server-timing-total-metricWordPress/performance:add/server-timing-total-metricCopy head branch name to clipboard
Mar 14, 2023
Merged

Add wp-total metric to default Server-Timing metrics#669
felixarntz merged 1 commit into
trunkWordPress/performance:trunkfrom
add/server-timing-total-metricWordPress/performance:add/server-timing-total-metricCopy head branch name to clipboard

Conversation

@felixarntz

@felixarntz felixarntz commented Mar 10, 2023

Copy link
Copy Markdown
Member

Summary

Fixes #668

  • Note that in order to see the metric, you need to enable output buffering via the Server Timing API filter. See this Gist.
  • This data (also see WordPress Trac ticket) is an example where the code from this PR was already used.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels Mar 10, 2023
@felixarntz felixarntz added this to the 2.1.0 milestone Mar 10, 2023
@felixarntz

Copy link
Copy Markdown
Member Author

cc @oandregal

@mukeshpanchal27 mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixarntz, LGTM!

Comment thread server-timing/defaults.php
@felixarntz
felixarntz merged commit a92b560 into trunk Mar 14, 2023
@felixarntz
felixarntz deleted the add/server-timing-total-metric branch March 14, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Server-Timing metric for total load time

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.