Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix: Use proper escape function#2246

Merged
mukeshpanchal27 merged 1 commit into
WordPress:trunkWordPress/performance:trunkfrom
DAnn2012:patch-1DAnn2012/performance:patch-1Copy head branch name to clipboard
Oct 31, 2025
Merged

Fix: Use proper escape function#2246
mukeshpanchal27 merged 1 commit into
WordPress:trunkWordPress/performance:trunkfrom
DAnn2012:patch-1DAnn2012/performance:patch-1Copy head branch name to clipboard

Conversation

@DAnn2012

@DAnn2012 DAnn2012 commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

Summary

Fixed Function in plugins.php

Relevant technical choices

Fixed Function in plugins.php

Use of AI Tools

@github-actions

github-actions Bot commented Oct 31, 2025 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @DAnn2012.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: DAnn2012.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov

codecov Bot commented Oct 31, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.86%. Comparing base (30d2332) to head (01ba0e5).
⚠️ Report is 2 commits behind head on trunk.

Files with missing lines Patch % Lines
plugins/performance-lab/includes/admin/plugins.php 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk    #2246   +/-   ##
=======================================
  Coverage   68.86%   68.86%           
=======================================
  Files          90       90           
  Lines        7610     7610           
=======================================
  Hits         5241     5241           
  Misses       2369     2369
Flag Coverage Δ
multisite 68.86% <0.00%> (ø)
single 35.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mukeshpanchal27
mukeshpanchal27 approved these changes Oct 31, 2025
View reviewed changes

@mukeshpanchal27 mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Oct 31, 2025
@mukeshpanchal27
mukeshpanchal27 merged commit 6888788 into WordPress:trunk Oct 31, 2025
21 of 25 checks passed
@mukeshpanchal27 mukeshpanchal27 changed the title Fixed Function in plugins.php Fix: Use proper escape function Oct 31, 2025
@westonruter

westonruter commented Oct 31, 2025

Copy link
Copy Markdown
Member

@DAnn2012 Thanks! I'm curious how you ran across this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes
@felixarntz felixarntz Awaiting requested review from felixarntz

Assignees

No one assigned

Labels

[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Bug An existing feature is broken

Projects

None yet

Milestone

performance-lab 4.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@DAnn2012 @westonruter @mukeshpanchal27
Morty Proxy This is a proxified and sanitized view of the page, visit original site.