Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Settings: replace CSS with Stack component#785

Merged
dkotter merged 1 commit into
WordPress:developWordPress/ai:developfrom
simison:update/settings-button-stacksimison/ai:update/settings-button-stackCopy head branch name to clipboard
Jun 29, 2026
Merged

Settings: replace CSS with Stack component#785
dkotter merged 1 commit into
WordPress:developWordPress/ai:developfrom
simison:update/settings-button-stacksimison/ai:update/settings-button-stackCopy head branch name to clipboard

Conversation

@simison

@simison simison commented Jun 26, 2026

Copy link
Copy Markdown
Member

What?

Follow up to #761 and few other PRs.

Replaces some manual CSS usage with Stack component.

Why?

  • Helps with UI consistency and using more WP design system overall.

How?

  • Replace CSS with Stack component.

Use of AI Tools

yes<!--
You are free to use artificial intelligence (AI) tooling to contribute, but you must disclose what tooling you are using and to what extent a pull request has been authored by AI. It is your responsibility to review and take responsibility for what AI generates. See the WordPress AI Guidelines: https://make.wordpress.org/ai/handbook/ai-guidelines/.

Example disclosure:

AI assistance: Yes
Tool(s): GitHub Copilot, ChatGPT
Model(s): GPT-5.1
Used for: Initial code skeleton and test suggestions; final implementation and tests were reviewed and edited by me.
-->

Testing Instructions

  • Smoke test "developer" mode settings in settings page. Nothing should visually look different from before.

Screenshots or screencast

Changelog Entry

Changed - Replace developer mode settings CSS with Stack component.

Open WordPress Playground Preview

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.50%. Comparing base (56cef56) to head (94dd15f).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #785   +/-   ##
==========================================
  Coverage      76.50%   76.50%           
  Complexity      1868     1868           
==========================================
  Files             89       89           
  Lines           7985     7985           
==========================================
  Hits            6109     6109           
  Misses          1876     1876           
Flag Coverage Δ
unit 76.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jeffpaul

Copy link
Copy Markdown
Member

@simison is this still in progress or can it come out of draft for review?

@jeffpaul jeffpaul moved this from Triage to In progress in WordPress AI Roadmap Jun 26, 2026
@simison

simison commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

Ok to review but I just didn't completely confirm before/after myself and take screenshots, but if it works for you this one would be ready to go! It's super simple.

@jeffpaul
jeffpaul marked this pull request as ready for review June 26, 2026 20:59
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: simison <simison@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jeffpaul jeffpaul moved this from In progress to Needs review in WordPress AI Roadmap Jun 26, 2026

@jeffpaul jeffpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via Playground and works as expected following test steps

@jeffpaul
jeffpaul requested a review from dkotter June 26, 2026 21:01
@dkotter
dkotter merged commit 6ff0502 into WordPress:develop Jun 29, 2026
27 checks passed
@github-project-automation github-project-automation Bot moved this from Needs review to Done in WordPress AI Roadmap Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.