Add additional properties to Room and fix missing arguments in rooms API#246
Merged
Joezanini merged 2 commits intoNov 8, 2024
mainWebexCommunity/WebexPythonSDK:mainfrom
feat/room/add-missing-propertiesWebexCommunity/WebexPythonSDK:feat/room/add-missing-propertiesCopy head branch name to clipboard
Merged
Add additional properties to Room and fix missing arguments in rooms API#246Joezanini merged 2 commits intomainWebexCommunity/WebexPythonSDK:mainfrom feat/room/add-missing-propertiesWebexCommunity/WebexPythonSDK:feat/room/add-missing-propertiesCopy head branch name to clipboard
Joezanini merged 2 commits into
mainWebexCommunity/WebexPythonSDK:mainfrom
feat/room/add-missing-propertiesWebexCommunity/WebexPythonSDK:feat/room/add-missing-propertiesCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes two commits; these changes enhance the functionality and completeness of the Room class and ensure that the rooms API works correctly.
The first commit adds additional properties to the Room class, including
classificationId,isAnnouncementOnly,isReadOnly,isPublic,madePublic, anddescription.The second commit fixes missing arguments in the rooms API by adding the create room args to the
post_data.Fixes #244