Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

"excludeMatches" array in scripting.registerContentScripts() API is ignored#43398

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainWebKit/WebKit:mainfrom
kiaraarose:eng/scripting-exclude-matcheskiaraarose/WebKit:eng/scripting-exclude-matchesCopy head branch name to clipboard
Apr 2, 2025
Merged

"excludeMatches" array in scripting.registerContentScripts() API is ignored#43398
webkit-commit-queue merged 1 commit into
WebKit:mainWebKit/WebKit:mainfrom
kiaraarose:eng/scripting-exclude-matcheskiaraarose/WebKit:eng/scripting-exclude-matchesCopy head branch name to clipboard

Conversation

@kiaraarose
Copy link
Copy Markdown
Contributor

@kiaraarose kiaraarose commented Apr 1, 2025 •
edited by webkit-early-warning-system
Loading

242d59d

 "excludeMatches" array in scripting.registerContentScripts() API is ignored
https://bugs.webkit.org/show_bug.cgi?id=290858
rdar://145489255

Reviewed by Timothy Hatcher.

Add the excluded match pattern to the excludeMatchPatterns set.

* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIScriptingCocoa.mm:
(WebKit::WebExtensionContext::createInjectedContentForScripts):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIScripting, RegisteredScriptExcludesMatches)):

Canonical link: https://commits.webkit.org/293106@main

a40e6ab

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp
  🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@kiaraarose kiaraarose self-assigned this Apr 1, 2025
@kiaraarose kiaraarose added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Apr 1, 2025
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 1, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 04cfe77)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

xeenon
xeenon approved these changes Apr 1, 2025
View reviewed changes
Comment thread Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm Outdated
@xeenon xeenon added WebKit Extensions Bugs related to extension support. and removed New Bugs Unclassified bugs are placed in this component until the correct component can be determined. labels Apr 1, 2025
@kiaraarose kiaraarose added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Apr 1, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 2, 2025
@kiaraarose kiaraarose removed the merging-blocked Applied to prevent a change from being merged label Apr 2, 2025
@kiaraarose kiaraarose force-pushed the eng/scripting-exclude-matches branch from 04cfe77 to a40e6ab Compare April 2, 2025 16:20
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 2, 2025 •
edited
Loading

EWS run on current version of this PR (hash a40e6ab)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp
  🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@kiaraarose kiaraarose added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Apr 2, 2025
@kiaraarose
"excludeMatches" array in scripting.registerContentScripts() API is …
242d59d 
…ignored

https://bugs.webkit.org/show_bug.cgi?id=290858
rdar://145489255

Reviewed by Timothy Hatcher.

Add the excluded match pattern to the excludeMatchPatterns set.

* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIScriptingCocoa.mm:
(WebKit::WebExtensionContext::createInjectedContentForScripts):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIScripting, RegisteredScriptExcludesMatches)):

Canonical link: https://commits.webkit.org/293106@main
@webkit-commit-queue webkit-commit-queue changed the title "excludeMatches" array in scripting.registerContentScripts() API is ignored "excludeMatches" array in scripting.registerContentScripts() API is ignored Apr 2, 2025
@webkit-commit-queue webkit-commit-queue force-pushed the eng/scripting-exclude-matches branch from a40e6ab to 242d59d Compare April 2, 2025 16:23
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Apr 2, 2025

Committed 293106@main (242d59d): https://commits.webkit.org/293106@main

Reviewed commits have been landed. Closing PR #43398 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 242d59d into WebKit:main Apr 2, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 2, 2025
@gorhill gorhill mentioned this pull request Apr 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xeenon xeenon xeenon approved these changes

@elijahsawyers elijahsawyers elijahsawyers approved these changes

@b-weinstein b-weinstein Awaiting requested review from b-weinstein b-weinstein is a code owner

Assignees

@kiaraarose kiaraarose

Labels

WebKit Extensions Bugs related to extension support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kiaraarose @webkit-early-warning-system @webkit-commit-queue @xeenon @elijahsawyers @webkit-ews-buildbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.