Avoid use of C++20 <ranges> header in GlobalEffects.cpp - #8668
#8668Merged
Merged
Avoid use of C++20 <ranges> header in GlobalEffects.cpp#8668
Conversation
This was referenced May 4, 2026
Merged
…code builds on Clang-14 as well.
Member
|
If we decide we want to support this we should also make sure we have some kind of CI bot that tests with this version of clang and/or xcode. |
tlively
approved these changes
May 4, 2026
juj
added a commit
that referenced
this pull request
May 5, 2026
Clang-13 advertises C++20 support with `__cplusplus >= 202002L`, but it does not have all the features of C++20. So instead use the C++20 individual feature testing macros to check for the various features: https://en.cppreference.com/cpp/feature_test which Clang-13 accurately reports. Authored on top of PR #8668, will rebase before landing, if/when #8668 is approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid use of C++20 header in GlobalEffects.cpp, so that the code builds on Clang-14 as well.