Account for global effects in LinearExecutionWalker - #8637
#8637Merged
Merged
Account for global effects in LinearExecutionWalker#8637
Conversation
stevenfontanella
force-pushed
the
linear-execution
branch
from
April 21, 2026 21:03
78c85f5 to
aa1086f
Compare
stevenfontanella
force-pushed
the
linear-execution
branch
from
April 21, 2026 21:10
aa1086f to
7a0ec79
Compare
stevenfontanella
force-pushed
the
linear-execution
branch
from
April 21, 2026 22:05
7a0ec79 to
cb4046f
Compare
Member
Author
|
Running the fuzzer now. |
Member
Author
Ran the fuzzer overnight for 17k iterations with no issues. |
kripken
reviewed
Apr 22, 2026
kripken
reviewed
Apr 22, 2026
kripken
reviewed
Apr 22, 2026
kripken
reviewed
Apr 22, 2026
aheejin
approved these changes
Apr 22, 2026
kripken
approved these changes
Apr 22, 2026
stevenfontanella
added a commit
that referenced
this pull request
Apr 23, 2026
After #8637 this works with -all.
stevenfontanella
added a commit
that referenced
this pull request
Apr 23, 2026
This now works after #8637
stevenfontanella
added a commit
that referenced
this pull request
May 23, 2026
Part of #8615. Follows up from #8637 now that global effects for indirect calls has been added. Allows LinearExecutionWalker to *not* halt and continue scanning when an indirect call is encountered in the case the global effects have been computed under `--closed-world` and we determined that the indirect call can't have any throw effects. LinearExecutionWalker is used in the following passes: * LocalGraph * LocalCSE * OptimizeCasts * SimplifyGlobals * SimplifyLocals * GUFA * TypeRefining
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When --enable-exception-handling is true, we previously assumed that every call throws in LinearExecutionWalker which prevented some opportunities for optimizing locals (and potentially other optimizations in passes that use this class). Change the code to make use of global effects when present.
The following passes use LinearExecutionWalker:
It's also used in ContentOracle which is used in GUFA and TypeRefining.