Merged
[emscripten] Fix handleFatalError to match recent emscripten changes#8521
Conversation
sbc100
requested review from
dschuff,
kripken and
stevenfontanella
and removed request for
a team
March 25, 2026 18:33
sbc100
force-pushed
the
handleFatalError
branch
from
March 25, 2026 18:38
4641f20 to
78417e8
Compare
Since emscripten-core/emscripten#26523 emscripten no longer throws raw pointers/numbers.
sbc100
force-pushed
the
handleFatalError
branch
from
March 25, 2026 18:38
78417e8 to
3a05e8f
Compare
sbc100
enabled auto-merge (squash)
March 25, 2026 18:54
dschuff
approved these changes
Mar 25, 2026
sbc100
disabled auto-merge
March 25, 2026 19:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since emscripten-core/emscripten#26523 emscripten no longer throws raw pointers/numbers.