This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Add check for comments that exceed DB col size - #2858
#2858Open
salcode wants to merge 2 commits into
WP-API:developWP-API/WP-API:developfrom
salcode:2785-comment-exceed-db-col-sizeCopy head branch name to clipboard
Open
Add check for comments that exceed DB col size#2858salcode wants to merge 2 commits intoWP-API:developWP-API/WP-API:developfrom salcode:2785-comment-exceed-db-col-sizeCopy head branch name to clipboard
salcode wants to merge 2 commits into
WP-API:developWP-API/WP-API:developfrom
salcode:2785-comment-exceed-db-col-sizeCopy head branch name to clipboard
Conversation
Add checks for these fields exceeding the DB col size and tests for each field: - comment_author - comment_author_email - comment_author_url - comment_content See #2785
Author
|
Thanks. |
Member
|
@salcode What do you think about moving this into the |
Member
|
This PR would also benefit from a few unit tests. |
Member
|
@rachelbaker, the original PR already includes the corresponding unit tests. |
Author
|
@rachelbaker thanks for your suggestion. I've moved the DB column size check to Currently, there are unit tests for create. Am I correct you're suggesting we add tests to cover update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add checks for these fields exceeding the DB col size and tests for each
field:
See #2785