This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Add date query for comments - #2291
#2291Merged
danielbachhuber merged 3 commits intoFeb 19, 2016
WP-API:developWP-API/WP-API:developfrom
BE-Webdesign:Add-date-query-for-commentsBE-Webdesign/WP-API:Add-date-query-for-commentsCopy head branch name to clipboard
Merged
Add date query for comments#2291danielbachhuber merged 3 commits intoWP-API:developWP-API/WP-API:developfrom BE-Webdesign:Add-date-query-for-commentsBE-Webdesign/WP-API:Add-date-query-for-commentsCopy head branch name to clipboard
danielbachhuber merged 3 commits into
WP-API:developWP-API/WP-API:developfrom
BE-Webdesign:Add-date-query-for-commentsBE-Webdesign/WP-API:Add-date-query-for-commentsCopy head branch name to clipboard
Conversation
Add before and after date query params to top level query arguments for comments endpoint. Tests for invalid date and valid date included.
Member
|
🚢 🚢 🚢 |
danielbachhuber
added a commit
that referenced
this pull request
Feb 19, 2016
Add date query for comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should add before and after parameters to the top level of query arguments for the comments endpoint. Similar to #2266 and the same functionality pretty much that goes for #2144 using posts. Use ISO8601 compliant date time strings!
Example:
GET wp/v2/comments/?after=2015-01-01T00:00:00Z&before=2017-01-01T00:00:00Z
For comments between January 1st, 2015 and January 1st, 2017.
Let me know what improvements can be made!