This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Fix content disposition parsing - #2239
#2239Merged
danielbachhuber merged 5 commits intoFeb 9, 2016
developWP-API/WP-API:developfrom
fix-content-disposition-parsingWP-API/WP-API:fix-content-disposition-parsingCopy head branch name to clipboard
Merged
Fix content disposition parsing#2239danielbachhuber merged 5 commits intodevelopWP-API/WP-API:developfrom fix-content-disposition-parsingWP-API/WP-API:fix-content-disposition-parsingCopy head branch name to clipboard
danielbachhuber merged 5 commits into
developWP-API/WP-API:developfrom
fix-content-disposition-parsingWP-API/WP-API:fix-content-disposition-parsingCopy head branch name to clipboard
Conversation
danielbachhuber
added a commit
that referenced
this pull request
Feb 9, 2016
Fix content disposition parsing
mjacobsen4DFM
added a commit
to mjacobsen4DFM/StormFront-Original
that referenced
this pull request
Oct 5, 2016
BREAKING CHANGE: Fix Content-Disposition header parsing. Allows regular form submissions from HTML forms, as well as properly formatted HTTP requests from clients. Note: this breaks backwards compatibility, as previously, the header parsing was completely wrong. (props @rmccue, #2239) WP-API/WP-API#2239
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1744. This should allow regular form submissions from HTML forms, as well as properly formatted HTTP requests from clients.
Note: this breaks backwards compatibility, as previously, the header parsing was completely wrong.