This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Merged
Provide embed and view as public contexts for users#2184
embed and view as public contexts for users#2184Conversation
Details historically in `view` have been moved to `edit`
embed and view are both expected to be public
Member
Author
|
@WP-API/amigos #reviewmerge |
Member
There was a problem hiding this comment.
Hmm this is somewhat new behaviour, as this is really "array of type", the valid values being the enums. We might be better of using the jsonSchema way of doing this, rather than inventing our own.
Member
Author
There was a problem hiding this comment.
Oh. I think I introduced this because roles ended up with an enum in my merge conflict:
'roles' => array(
'description' => __( 'Roles assigned to the resource.' ),
'type' => 'array',
'context' => array( 'edit' ),
'enum' => array_keys( $wp_roles->role_objects ),
),
I'll revert for now.
rmccue
added a commit
that referenced
this pull request
Feb 4, 2016
Provide `embed` and `view` as public contexts for users
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details historically in
viewhave been moved toeditFixes #1869
Related #1845