Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Add Periods to Short, Long Dec and Inline Comments - #1698

#1698
Merged
danielbachhuber merged 3 commits into
WP-API:developWP-API/WP-API:developfrom
ahmadawais:patch-1ahmadawais/WP-API:patch-1Copy head branch name to clipboard
Oct 29, 2015
Merged

Add Periods to Short, Long Dec and Inline Comments#1698
danielbachhuber merged 3 commits into
WP-API:developWP-API/WP-API:developfrom
ahmadawais:patch-1ahmadawais/WP-API:patch-1Copy head branch name to clipboard

Conversation

@ahmadawais

Copy link
Copy Markdown
Contributor

This commit Adda Periods to Short, Long Dec and Inline Comments in accordance with WP JS documentation standards.

Add Periods to Short, Long Dec and Inline Comments
Comment thread wp-api.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it makes sense to add a period here, as it changes the nature of the URL.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me re-submit this PR and I will add @link tags for these URLs without a period at the end, as suggested in the core handbook.

Comment thread wp-api.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No period

@danielbachhuber

Copy link
Copy Markdown
Member

There are a number of instances where the period needs to be removed.

@ahmadawais

Copy link
Copy Markdown
Contributor Author

@danielbachhuber I have updated the file and removed the unnecessary periods.

@danielbachhuber danielbachhuber added this to the 2.0 Beta 6 milestone Oct 29, 2015
danielbachhuber added a commit that referenced this pull request Oct 29, 2015
Add Periods to Short, Long Dec and Inline Comments
@danielbachhuber
danielbachhuber merged commit 645b9c0 into WP-API:develop Oct 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.