Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Return the trashed status of delete posts/comments - #1499

#1499
Merged
rachelbaker merged 14 commits into
WP-API:developWP-API/WP-API:developfrom
pento:developpento/WP-API:developCopy head branch name to clipboard
Sep 16, 2015
Merged

Return the trashed status of delete posts/comments#1499
rachelbaker merged 14 commits into
WP-API:developWP-API/WP-API:developfrom
pento:developpento/WP-API:developCopy head branch name to clipboard

Conversation

@pento

@pento pento commented Aug 24, 2015

Copy link
Copy Markdown
Member

When a post or a comment is deleted, return a flag to say whether it's been trashed or properly deleted.

See #1260.

@pento

pento commented Aug 24, 2015

Copy link
Copy Markdown
Member Author

Okay, I give up on Scrutinizer. Let's commit it.

@pento pento added the Review label Aug 25, 2015
@pento

pento commented Aug 25, 2015

Copy link
Copy Markdown
Member Author

Ready for review @WP-API/amigos.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this after the comment has been deleted, I think it's possible some preparation might fail here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, moved back to its original position.

It was moved in an early revision, but no longer needs to be. It can go
back now.
@pento pento added this to the 2.0 Beta 5 milestone Aug 25, 2015
rachelbaker added a commit that referenced this pull request Sep 16, 2015
Return the trashed status of delete posts/comments
@rachelbaker
rachelbaker merged commit 77ca5b0 into WP-API:develop Sep 16, 2015
@rachelbaker

Copy link
Copy Markdown
Member

Merged #1499

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.