This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Embed links inside items in a collection - #1459
#1459Merged
Merged
Embed links inside items in a collection#1459
Conversation
Member
|
@rmccue well the PHPCS task is still working :P https://travis-ci.org/WP-API/WP-API/jobs/74231936 |
rachelbaker
added a commit
that referenced
this pull request
Aug 5, 2015
Embed links inside items in a collection
Member
|
Merged #1459 |
kwight
added a commit
to kwight/wp-api-theming
that referenced
this pull request
Sep 7, 2015
These are no longer necessary with the merge of WP-API/WP-API#1459.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #865
This is a very simple approach. Essentially: if you return a list from your endpoint, apply
embed_linksto the items inside that rather than the top-level.If we switch collections to objects, we can handle this differently, but that's a separate issue at #1196.