Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Only link author when there's a valid author - #1203

#1203
Merged
joehoyle merged 3 commits into
developWP-API/WP-API:developfrom
1192-no-zero-author-linkWP-API/WP-API:1192-no-zero-author-linkCopy head branch name to clipboard
May 8, 2015
Merged

Only link author when there's a valid author#1203
joehoyle merged 3 commits into
developWP-API/WP-API:developfrom
1192-no-zero-author-linkWP-API/WP-API:1192-no-zero-author-linkCopy head branch name to clipboard

Conversation

@danielbachhuber

Copy link
Copy Markdown
Member

Fixes #1192

@danielbachhuber

Copy link
Copy Markdown
Member Author

@WP-API/amigos #reviewmerge

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why do we whitelist the post types here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To force the data to always be present, even if the developer has removed post type supports.

Our posts and pages are fixed schemas. Except not, of course.

joehoyle added a commit that referenced this pull request May 8, 2015
Only link `author` when there's a valid author
@joehoyle
joehoyle merged commit ac9a324 into develop May 8, 2015
@joehoyle
joehoyle deleted the 1192-no-zero-author-link branch May 8, 2015 00:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't link author when author=0

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.