Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Pagination headers for comment collection queries - #1197

#1197
Merged
danielbachhuber merged 2 commits into
developWP-API/WP-API:developfrom
1186-comments-paginationWP-API/WP-API:1186-comments-paginationCopy head branch name to clipboard
May 7, 2015
Merged

Pagination headers for comment collection queries#1197
danielbachhuber merged 2 commits into
developWP-API/WP-API:developfrom
1186-comments-paginationWP-API/WP-API:1186-comments-paginationCopy head branch name to clipboard

Conversation

@danielbachhuber

Copy link
Copy Markdown
Member

Fixes #1186

@danielbachhuber

Copy link
Copy Markdown
Member Author

@WP-API/amigos #reviewmerge

@danielbachhuber

Copy link
Copy Markdown
Member Author

Hm. I have no idea why this test is failing.

@joehoyle

joehoyle commented May 7, 2015

Copy link
Copy Markdown
Member

@danielbachhuber due to the larger amount of tests the "invalid" id's actually existed. I updated to a sufficiently high number to avoid this.

@danielbachhuber

Copy link
Copy Markdown
Member Author

Classic. Thanks!

danielbachhuber pushed a commit that referenced this pull request May 7, 2015
Pagination headers for comment collection queries
@danielbachhuber
danielbachhuber merged commit fb1d99e into develop May 7, 2015
@danielbachhuber
danielbachhuber deleted the 1186-comments-pagination branch May 7, 2015 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paginate comment queries and limit by default

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.