Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: solve add row column plugin release issue #5140 - #5148

#5148
Merged
fangsmile merged 1 commit into
developVisActor/VTable:developfrom
fix/issue-5140-add-row-column-plugin-releaseVisActor/VTable:fix/issue-5140-add-row-column-plugin-releaseCopy head branch name to clipboard
May 25, 2026
Merged

fix: solve add row column plugin release issue #5140#5148
fangsmile merged 1 commit into
developVisActor/VTable:developfrom
fix/issue-5140-add-row-column-plugin-releaseVisActor/VTable:fix/issue-5140-add-row-column-plugin-releaseCopy head branch name to clipboard

Conversation

@fangsmile

Copy link
Copy Markdown
Contributor

Summary

  • fix AddRowColumnPlugin.release() so cleanup is safe when only row or only column controls are enabled
  • add a focused regression test for releasing the plugin with partial controls enabled
  • add a Rush change file for @visactor/vtable-plugins

Verification

  • inspect the plugin implementation path that calls remove() on optional DOM nodes
  • verify diagnostics for edited files
  • note: pnpm -C packages/vtable-plugins test -- add-row-column-plugin.test.ts is currently blocked by the existing Jest/ESM environment issue before the new test executes

@fangsmile
fangsmile merged commit 5fecf17 into develop May 25, 2026
7 of 8 checks passed
@fangsmile
fangsmile deleted the fix/issue-5140-add-row-column-plugin-release branch May 25, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.