Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: support dynamic legend pager layout and position - #4630

#4630
Closed
g1f9 wants to merge 1 commit into
VisActor:developVisActor/VChart:developfrom
g1f9:feat/legend-pager-layout-position-functionsg1f9/VChart:feat/legend-pager-layout-position-functionsCopy head branch name to clipboard
Closed

feat: support dynamic legend pager layout and position#4630
g1f9 wants to merge 1 commit into
VisActor:developVisActor/VChart:developfrom
g1f9:feat/legend-pager-layout-position-functionsg1f9/VChart:feat/legend-pager-layout-position-functionsCopy head branch name to clipboard

Conversation

@g1f9

@g1f9 g1f9 commented Jul 22, 2026

Copy link
Copy Markdown

Summary

  • allow pager.layout and pager.position to be configured as layout-time callbacks
  • evaluate both callbacks after dynamic maxRow / maxCol have been resolved
  • expose rect, resolved orient, legend id, maxRow, and maxCol through a shared callback context
  • preserve existing static string configurations and scrollbar behavior
  • document the callback API in English and Chinese

Motivation

Multi-row discrete legends may need vertically arranged pager handlers aligned to the first row, while single-row legends should retain a horizontal, centered pager. Resolving these values during layout lets the pager follow responsive row and column counts.

Validation

  • discrete legend callback unit coverage for dynamic and static layout / position
  • verified callback order after maxRow / maxCol resolution
  • verified resize transitions between single-row and multi-row results
  • verified generated CJS, ESM, and public TypeScript declarations
  • downstream split-render acceptance completed with a real multi-row legend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.