Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Skip pdf normalization - #473

#473
Merged
SimonCropp merged 3 commits into
mainVerifyTests/Verify.QuestPDF:mainfrom
skip-pdf-normalizationVerifyTests/Verify.QuestPDF:skip-pdf-normalizationCopy head branch name to clipboard
Jul 23, 2026
Merged

Skip pdf normalization#473
SimonCropp merged 3 commits into
mainVerifyTests/Verify.QuestPDF:mainfrom
skip-pdf-normalizationVerifyTests/Verify.QuestPDF:skip-pdf-normalizationCopy head branch name to clipboard

Conversation

@SimonCropp

Copy link
Copy Markdown
Member

No description provided.

Ports the SkipPdfNormalization setting from Verify.PDFium (3fd22e9).

Adds a SettingsTask/VerifySettings extension backed by a context key, so a caller
whose producer already emits byte-deterministic documents can snapshot the bytes
as produced. Normalizing those again copies the buffer, rescans it, and — when
the XMP packet is canonicalized — rebuilds it and repairs the cross-reference
table, all to change nothing.

Default behaviour is unchanged: without the setting the bytes are normalized.

SkipPdfNormalizationTests asserts the pairing rather than just that the setting
round-trips: the skipped snapshot holds the producer's own bytes and the default
one holds the neutralized bytes. A premise test pins that the sample is not
already normalization-invariant, so the pair cannot both pass vacuously.
@SimonCropp SimonCropp added this to the 2.9.0 milestone Jul 23, 2026
@SimonCropp
SimonCropp merged commit a9c87d3 into main Jul 23, 2026
4 of 6 checks passed
@SimonCropp
SimonCropp deleted the skip-pdf-normalization branch July 23, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.