In-place sort instead of LINQ OrderByDescending - #1710
#1710Merged
SimonCropp merged 1 commit intoApr 7, 2026
mainVerifyTests/Verify:mainfrom
In-place-sort-instead-of-LINQ-OrderByDescendingVerifyTests/Verify:In-place-sort-instead-of-LINQ-OrderByDescendingCopy head branch name to clipboard
Merged
In-place sort instead of LINQ OrderByDescending#1710SimonCropp merged 1 commit intomainVerifyTests/Verify:mainfrom In-place-sort-instead-of-LINQ-OrderByDescendingVerifyTests/Verify:In-place-sort-instead-of-LINQ-OrderByDescendingCopy head branch name to clipboard
SimonCropp merged 1 commit into
mainVerifyTests/Verify:mainfrom
In-place-sort-instead-of-LINQ-OrderByDescendingVerifyTests/Verify:In-place-sort-instead-of-LINQ-OrderByDescendingCopy head branch name to clipboard
Conversation
SimonCropp
commented
Apr 7, 2026
Member
- GuidScrubber.cs:19 — called on every GUID scrub operation
- UserMachineScrubber_PerformReplacements.cs:16 — called on every user/machine scrub
- DirectoryReplacements_StringBuilder.cs:43 — called on every directory replacement
- Eliminates IOrderedEnumerable wrapper allocation + deferred execution overhead. List.Sort is in-place with zero allocation.
- GuidScrubber.cs:19 — called on every GUID scrub operation - UserMachineScrubber_PerformReplacements.cs:16 — called on every user/machine scrub - DirectoryReplacements_StringBuilder.cs:43 — called on every directory replacement - Eliminates IOrderedEnumerable wrapper allocation + deferred execution overhead. List.Sort is in-place with zero allocation.
This was referenced Apr 16, 2026
Merged
This was referenced Jun 19, 2026
This was referenced Jul 1, 2026
This was referenced Jul 8, 2026
This was referenced Jul 15, 2026
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.