-
Notifications
You must be signed in to change notification settings - Fork 449
fix: PVP issues related to assemblies, file names, and other non-xml-API related #3444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NoelStephensUnity
merged 26 commits into
develop-2.0.0
from
reference/pvp-133-132-130-issues
Jun 6, 2025
Merged
fix: PVP issues related to assemblies, file names, and other non-xml-API related #3444
NoelStephensUnity
merged 26 commits into
develop-2.0.0
from
reference/pvp-133-132-130-issues
Jun 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing space at end of line. Minor private comment fixes.
Fixing the remaining PVP-151-1 errors.
Fixing some stragglers.
>.< Last 3 stragglers.
Fixing some Xml format issues.
Removed the single white space at the end of a comment.
Fixing one of the PVP-132-2 issues.
Moving code gen into Runtime and removing the editor portion of the assembly name seems to do the trick. (as long as x-ray thinks this is valid)
This reverts commit 08db094.
michalChrobot
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PVP Fixes
This includes fixes for all remaining NGO v2.x PVP errors.
Depends upon PR-720
Changelog
NA
Testing and Documentation
[Obsolete]
to a couple of legacy test related methods not used by anything.Deprecated API
[Obsolete]
attribute was added.[Obsolete]
attribute was added along with a(RemovedAfter yyyy-mm-dd)
entry.Backport
A backport similar to this will be required but will not be these specific changes.