Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: PVP issues related to assemblies, file names, and other non-xml-API related #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jun 6, 2025

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented May 13, 2025

PVP Fixes

This includes fixes for all remaining NGO v2.x PVP errors.

Depends upon PR-720

Changelog

NA

Testing and Documentation

  • Tools tests have been migrated to multiplayer tools repository.
  • Tools test project was removed.
  • Includes adding [Obsolete] to a couple of legacy test related methods not used by anything.
  • Includes updating tests or test related classes, enums, structs (all unique for existing NGO tests) from being public to internal.
  • Includes XML API documentation changes.

Deprecated API

  • An [Obsolete] attribute was added.
  • An [Obsolete] attribute was added along with a (RemovedAfter yyyy-mm-dd) entry.
  • An [api updater] was added.
  • Deprecation of the API is explained in the CHANGELOG.
  • The users can understand why this API was removed and what they should use instead.

Backport

A backport similar to this will be required but will not be these specific changes.

This includes some (not all) fixes for:
PVP-133-2
PVP-130-2
Removing space at end of line.
Minor private comment fixes.
Updating manifest to do a test run with the modified tools repository/
Removing all of the tools related tests from NGO package.
Removing the scene event tests.
Missed one internal visibility even though it doesn't impact anything (yet).
Re-base merge fix.
Adding the test project's tests assembly to internals.
checking if the bokken image ubuntu-22.04:v4.72.0 recently updated is the cause of our failurs.
Migrating TestHelpers into the NGO SDK tests runtime folder.
Adjusting test project for this update.
Removing the tools tests.
Fixing the remaining PVP-151-1 errors.
Fixing some stragglers.
>.<
Last 3 stragglers.
Fixing some Xml format issues.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review June 6, 2025 00:37
@NoelStephensUnity NoelStephensUnity requested review from EmandM and a team as code owners June 6, 2025 00:37
michalChrobot and others added 6 commits June 6, 2025 15:43
Removed the single white space at the end of a comment.
Fixing one of the PVP-132-2 issues.
Fixing meta file with merge information in it.
Moving code gen into Runtime and removing the editor portion of the assembly name seems to do the trick.
(as long as x-ray thinks this is valid)
After looking around internally it appears that there is no way to get around this one particular issue.
Adding an exception for the Unity.Netcode.Editor.CodeGen since access to Unity.CompilationPipeline requires the assembly to end with ".CodeGen".
@NoelStephensUnity NoelStephensUnity merged commit a3e41f5 into develop-2.0.0 Jun 6, 2025
33 checks passed
@NoelStephensUnity NoelStephensUnity deleted the reference/pvp-133-132-130-issues branch June 6, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.