Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ci: [Backport] NGO CI update and rewrite [1.X] (#3193)#3283

Merged
NoelStephensUnity merged 28 commits intodevelopUnity-Technologies/com.unity.netcode.gameobjects:developfrom
NGO-CI-rewrite-for-developUnity-Technologies/com.unity.netcode.gameobjects:NGO-CI-rewrite-for-developCopy head branch name to clipboard
Feb 13, 2025
Merged

ci: [Backport] NGO CI update and rewrite [1.X] (#3193)#3283
NoelStephensUnity merged 28 commits intodevelopUnity-Technologies/com.unity.netcode.gameobjects:developfrom
NGO-CI-rewrite-for-developUnity-Technologies/com.unity.netcode.gameobjects:NGO-CI-rewrite-for-developCopy head branch name to clipboard

Conversation

@michalChrobot
Copy link
Member

@michalChrobot michalChrobot commented Feb 11, 2025

This PR is a backport of #3193 and aims to include

  • Refactor of CI setup, jobs and triggers
  • Disabling some tests which failing on mobile devices
  • Confirmed exceptions in existing pvpExceptions file

Notable difference is that manifest lists more editors since develop supports editors from 2021.3 (in contrast to develop-2.0.0 which supports from 6000.0)

Resolved:

Another change worth noticing is a fix for Standards fail within NGO package which states:
[14:08:00.316 Information] /home/bokken/build/output/Unity-Technologies/com.unity.netcode.gameobjects/com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs(1236,28): error CS0618: 'NetworkDriver.RemoteEndPoint(NetworkConnection)' is obsolete: 'RemoteEndPoint has been renamed to GetRemoteEndpoint. (UnityUpgradable) -> GetRemoteEndpoint(*)'

michalChrobot and others added 2 commits February 11, 2025 10:48
* Refactor of CI setup, jobs and triggers
* Disabling some tests which failing on mobile devices
* Setting up Renovate bot configuration (same as already present in develop branch)
* Added pvpExceptions file

---------

Co-authored-by: NoelStephensUnity <noel.stephens@unity3d.com>
@michalChrobot michalChrobot marked this pull request as ready for review February 11, 2025 10:01
@michalChrobot michalChrobot self-assigned this Feb 11, 2025
@michalChrobot michalChrobot added the port:2.x-completed This issue was ported to 2.X branch label Feb 11, 2025
…orkConnection)' is obsolete: 'RemoteEndPoint has been renamed to GetRemoteEndpoint. (UnityUpgradable) -> GetRemoteEndpoint(*)'"
@michalChrobot michalChrobot requested a review from a team as a code owner February 11, 2025 14:46
@NoelStephensUnity NoelStephensUnity changed the title build: [Backport] NGO CI update and rewrite [1.X] (#3193) ci: [Backport] NGO CI update and rewrite [1.X] (#3193) Feb 11, 2025
michalChrobot and others added 3 commits February 11, 2025 16:29
…int(NetworkConnection)' is obsolete: 'RemoteEndPoint has been renamed to GetRemoteEndpoint. (UnityUpgradable) -> GetRemoteEndpoint(*)'""

This reverts commit 7ccdd89.
.yamato/_triggers.yml Outdated Show resolved Hide resolved
.yamato/_triggers.yml Outdated Show resolved Hide resolved
NoelStephensUnity and others added 7 commits February 11, 2025 18:43
NGO v1.x compatibility for UTP v2.x
Minor adjustment for the legacy NetworkEndPoint name.
More UTP v2x related (collections etc.) defines required.
Missed one of the files
Copy link
Member

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should be good to go at this point!
Thank you @michalChrobot for all of the time and patience on this PR!
🥇

@NoelStephensUnity NoelStephensUnity merged commit 215dda2 into develop Feb 13, 2025
40 checks passed
@NoelStephensUnity NoelStephensUnity deleted the NGO-CI-rewrite-for-develop branch February 13, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

port:2.x-completed This issue was ported to 2.X branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.