Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Extended timeout for validation jobs on editors lower than 6000 to 5h #3173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

michalChrobot
Copy link
Collaborator

Extending timeout even more due to timing failures

@michalChrobot michalChrobot self-assigned this Dec 12, 2024
@michalChrobot michalChrobot marked this pull request as ready for review December 12, 2024 14:21
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think we could have gotten away with 3 hours...at this point I am thinking providing plenty of room for the ancillary post validation test stuff to finish is a good idea.

@NoelStephensUnity NoelStephensUnity merged commit 109eded into release/1.12.0 Dec 12, 2024
23 checks passed
@NoelStephensUnity NoelStephensUnity deleted the extended-timeouts branch December 12, 2024 21:25
michalChrobot added a commit that referenced this pull request Dec 15, 2024
)

* Added setup necessary for release automation of NGO (#3141)

* Corrected license file

* Removed old files not conforming to pvp rules

* Corrected typo in changelog

* Added samples description to package.json while removing deprecated .samples.json

* Inclusion of CI generation files

* Changed Samples folder name to Samples~

* Added path field in package.json for samples

* fix: removing timeouts from integration tests (#3167)

Removing timesouts from our integration tests:
- TestSendingWithGroupOverride
- TestSendingWithGroupNotOverride
- WhenManyObjectsAreSpawnedAtOnce_AllAreReceived(

* fix: update universal rpc tests revert spawnmany timeout (#3168)

* fix: adding extended timeout to all universal rpc tests (#3170)

Adding extended timeout to all universal rpc tests

* Extended timeout for validation jobs on editors lower than 6000 to 5h (#3173)

---------

Co-authored-by: Noel Stephens <noel.stephens@unity3d.com>
NoelStephensUnity added a commit that referenced this pull request Jan 10, 2025
* update

incrementing the version number and updating changelog to match version number.

* Added setup necessary for release automation of NGO (#3141)

generated files for release automation within Unity org

* fix: networklist editor memory leak [backport] (#3148)

* fix

This fixes the issue with NetworkLists on in-scene placed NetworkObjects causing small memory leaks when entering and exiting playmode.

* update

adding changelog entry

* update

adding PR number to log entry

* Corrected setup necessary for release automation of NGO (#3149)

* generated files for release automation within Unity org

* Corrected pvp profiles check

* Chore/phase 1 api documentation update 1 12 0 (#3158)

* Update README.md

Adding note about where to find the NGO v2 branch along with the examples.

* chore: api documentation phase 1 [backport] (#3157)

* update

updating XML API documentation for ConnectionEvent and ConnectionEventData.

* update

Updating XML API documentation for RpcTargetUse.

* Update com.unity.netcode.gameobjects/Runtime/Messaging/RpcTargets/RpcTarget.cs

Co-authored-by: Emma <emma.mcmillan@unity3d.com>

* Update com.unity.netcode.gameobjects/Runtime/Messaging/RpcTargets/RpcTarget.cs

Co-authored-by: Emma <emma.mcmillan@unity3d.com>

---------

Co-authored-by: Emma <emma.mcmillan@unity3d.com>

---------

Co-authored-by: Emma <emma.mcmillan@unity3d.com>

* PVP and Wrench fixes

* Updated wrench version to 0.10.30

* Corrected license file

* Removed old files not conforming to pvp rules

* Corrected typo in changelog

* Added samples description to package.json while removing deprecated .samples.json

* Inclusion of CI generation files

* Pvp fixes for automated release

* Changed Samples folder name to Samples~

* Added path field in package.json for samples

* Increased wrench timeout for editors below 6000

* Increasing wrench timeout to 2h for wrench validation jobs

* Timeout of validation jobs increased to 2h for editors below 6000

* fix: removing timeouts from integration tests (#3167)

fix

Removing timesouts from our integration tests:
- TestSendingWithGroupOverride
- TestSendingWithGroupNotOverride
- WhenManyObjectsAreSpawnedAtOnce_AllAreReceived(

* fix: update universal rpc tests revert spawnmany timeout (#3168)

* update

reverting the removal of the timeout.
making it actually 6 minutes.

* fix

Using the NGO v2. version of the UniversalRpcTestSendingWithGroupNotOverride and TestSendingWithGroupOverride tests.

* fix (#3169)

ignoring the two failing tests.

* fix: adding extended timeout to all universal rpc tests (#3170)

fix

Adding extended timeout to all universal rpc tests

* Extended timeout for validation jobs on editors lower than 6000 to 5h (#3173)

* update

Adding change log entry for this PR.

* update

removing changelog entry as that belong to a different PR.

---------

Co-authored-by: Michał Chrobot <124174716+michalChrobot@users.noreply.github.com>
Co-authored-by: Emma <emma.mcmillan@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.