fix: NetworkObject.SpawnWithObservers was not being honored for late joining clients [MTT-6934] #2623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadauxCat
reviewed
Jul 12, 2023
| - Fixed a failing UTP test that was failing when you install Unity Transport package 2.0.0 or newer. | ||
|
|
||
| - Fixed issue where `NetworkObject.SpawnWithObservers` was not being honored for late joining clients. (#2623) | ||
| - Fixed a failing UTP test that was failing when you install Unity Transport package 2.0.0 or newer. (#2616) |
There was a problem hiding this comment.
"Not your change", heh... but...
I asked Frank to remove this changelog in the release PR, can we remove it here too since you're touching it anyway? I don't generally think we need to broadcast test changes.
ShadauxCat
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue where
NetworkObject.SpawnWithObserverswas not being honored for late joining clients.MTT-6934
fix: #2609
Changelog
NetworkObject.SpawnWithObserverswas not being honored for late joining clients.Testing and Documentation
NetworkObjectOnSpawnTests.