fix: avoid throwing exception when using NetworkList without a NetworkManager (#2539) #2540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6081b6e to
b1feb94
Compare
com.unity.netcode.gameobjects/Runtime/NetworkVariable/Collections/NetworkList.cs
Outdated
Show resolved
Hide resolved
8dc63f2 to
844acdb
Compare
EmandM
reviewed
May 26, 2025
com.unity.netcode.gameobjects/Runtime/NetworkVariable/Collections/NetworkList.cs
Outdated
Show resolved
Hide resolved
844acdb to
fd18093
Compare
|
Thanks for the update! Just to check that we're not landing an incomplete fix, have you used this branch with your project? Does it resolve the issue you're needing resolved? |
fd18093 to
5e06bf1
Compare
|
Yes, I do use this fix in my project for two years. This PR just adds the same check as you already do in the NetworkVariable here: I also have rebased my branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2539
This PR add a check that m_NetworkBehaviour is not null before calling the
CanClientWritefunction.I did it exactly the same way it's already done for NetworkVariable.
With this PR, operations on the list are done and throws the anyoning warning (
NetworkVariable<T>do the same)Changelog
NetworkListthrowing exception when used without a NetworkManager in scene. (Can't do operations onNetworkListwith noNetworkManager(offline) #2539)Testing and Documentation