fix: dedupe boxplot ticks on shared axes#632
Closed
saschabuehrle wants to merge 1 commit into
Closed
fix: dedupe boxplot ticks on shared axes#632saschabuehrle wants to merge 1 commit into
saschabuehrle wants to merge 1 commit into
Conversation
Collaborator
|
Thanks! Closing in favor of #630 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes #628 — with shared x-axes, repeated
boxplot()calls can leave duplicated tick positions/labels (e.g.0..9rendered twice), which causes doubled/bold tick labels.Fix
boxplotcall, deduplicate managed axis tick positions while preserving order.manage_ticksis active, so explicit tick management still behaves as requested.Tests
test_boxplot_shared_x_does_not_duplicate_tickspytest ultraplot/tests/test_statistical_plotting.py -k boxplot_shared_x_does_not_duplicate_ticksHappy to adjust if you prefer a different location for the dedupe logic.
Greetings, saschabuehrle