CI: use live base tip for mpl baseline generation#580
Merged
cvanelteren merged 2 commits intoFeb 11, 2026
mainUltraplot/UltraPlot:mainfrom
fix/ci-baseline-base-tipUltraplot/UltraPlot:fix/ci-baseline-base-tipCopy head branch name to clipboard
Merged
CI: use live base tip for mpl baseline generation#580cvanelteren merged 2 commits intomainUltraplot/UltraPlot:mainfrom fix/ci-baseline-base-tipUltraplot/UltraPlot:fix/ci-baseline-base-tipCopy head branch name to clipboard
cvanelteren merged 2 commits into
mainUltraplot/UltraPlot:mainfrom
fix/ci-baseline-base-tipUltraplot/UltraPlot:fix/ci-baseline-base-tipCopy head branch name to clipboard
Conversation
Fix repeated centered-legend image mismatches across PRs caused by comparing against stale baseline commits from pull_request payload SHA. Workflow changes: resolve base ref/sha at runtime from origin/<base.ref>, use that SHA for cache key and baseline checkout, and bump baseline cache namespace to v4 to invalidate stale cache entries.
K-Mirembe-Mercy
pushed a commit
to K-Mirembe-Mercy/UltraPlot
that referenced
this pull request
Mar 22, 2026
Fix repeated centered-legend image mismatches across PRs caused by comparing against stale baseline commits from pull_request payload SHA. Workflow changes: resolve base ref/sha at runtime from origin/<base.ref>, use that SHA for cache key and baseline checkout, and bump baseline cache namespace to v4 to invalidate stale cache entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes recurring image-compare failures (notably test_centered_legends) across PRs where the compare job was generating and restoring baselines keyed by github.event.pull_request.base.sha, which can be stale relative to the current base branch tip.
Changes:
This keeps baseline generation aligned with the actual current base branch and avoids persistent false diffs caused by old baseline snapshots.