Feature: Add histtype option for ridgeline histograms#557
Merged
cvanelteren merged 12 commits intoFeb 12, 2026
mainUltraplot/UltraPlot:mainfrom
feat/ridgeline-histtypeUltraplot/UltraPlot:feat/ridgeline-histtypeCopy head branch name to clipboard
Merged
Feature: Add histtype option for ridgeline histograms#557cvanelteren merged 12 commits intomainUltraplot/UltraPlot:mainfrom feat/ridgeline-histtypeUltraplot/UltraPlot:feat/ridgeline-histtypeCopy head branch name to clipboard
cvanelteren merged 12 commits into
mainUltraplot/UltraPlot:mainfrom
feat/ridgeline-histtypeUltraplot/UltraPlot:feat/ridgeline-histtypeCopy head branch name to clipboard
Conversation
for more information, see https://pre-commit.ci
Collaborator
Author
|
Maybe this is a good tester to get the review going on @munechika-koyo |
(cherry picked from commit 1ff58be)
beckermr
approved these changes
Feb 12, 2026
Collaborator
Author
|
Thanks @beckermr, do you have any additional comments @munechika-koyo? |
munechika-koyo
approved these changes
Feb 12, 2026
| if hist and histtype is None: | ||
| histtype = "fill" | ||
| if hist: | ||
| allowed = ("fill", "bar", "step", "stepfilled") |
There was a problem hiding this comment.
Suggested change
| allowed = ("fill", "bar", "step", "stepfilled") | |
| allowed = {"fill", "bar", "step", "stepfilled"} |
| zorder=fill_zorder, | ||
| ) | ||
| # Draw outline on top (excluding baseline) | ||
| elif is_hist and histtype in ("step", "stepfilled"): |
There was a problem hiding this comment.
Suggested change
| elif is_hist and histtype in ("step", "stepfilled"): | |
| elif is_hist and histtype in {"step", "stepfilled"}: |
|
I made a few comments that aren't particularly critical. |
K-Mirembe-Mercy
pushed a commit
to K-Mirembe-Mercy/UltraPlot
that referenced
this pull request
Mar 22, 2026
* Add histtype option for ridgeline histograms * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Refresh baseline cache key for hash-seed-stable compares (cherry picked from commit 1ff58be) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a Matplotlib-style histtype option for ridgeline(hist=True) to support bar, step, and stepfilled rendering in addition to the existing filled ridge. The change preserves current defaults, adds validation, and includes a basic test to ensure bar-style ridgelines render without error.