Use PR-selected nodeids for mpl baselines and skip empty selections#535
Merged
cvanelteren merged 3 commits intoFeb 1, 2026
mainUltraplot/UltraPlot:mainfrom
fix/mpl-selected-nodeidsUltraplot/UltraPlot:fix/mpl-selected-nodeidsCopy head branch name to clipboard
Merged
Use PR-selected nodeids for mpl baselines and skip empty selections#535cvanelteren merged 3 commits intomainUltraplot/UltraPlot:mainfrom fix/mpl-selected-nodeidsUltraplot/UltraPlot:fix/mpl-selected-nodeidsCopy head branch name to clipboard
cvanelteren merged 3 commits into
mainUltraplot/UltraPlot:mainfrom
fix/mpl-selected-nodeidsUltraplot/UltraPlot:fix/mpl-selected-nodeidsCopy head branch name to clipboard
Conversation
K-Mirembe-Mercy
pushed a commit
to K-Mirembe-Mercy/UltraPlot
that referenced
this pull request
Mar 22, 2026
…ltraplot#535) * Add threaded rc cycle consistency test * Limit mpl baselines to selected nodeids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the mpl workflow to reuse the PR-selected nodeids when generating baselines on the base commit and during PR image comparison. The nodeids are saved before checkout, filtered against the base/PR filesystem, and if none are valid or collected, the job now skips instead of falling back to the full suite. This prevents timeouts and keeps baseline generation scoped to the intended tests.