Fix log formatter tickrange crash#507
Merged
cvanelteren merged 7 commits intoJan 27, 2026
mainUltraplot/UltraPlot:mainfrom
fix-log-formatter-tickrangeUltraplot/UltraPlot:fix-log-formatter-tickrangeCopy head branch name to clipboard
Merged
Fix log formatter tickrange crash#507cvanelteren merged 7 commits intomainUltraplot/UltraPlot:mainfrom fix-log-formatter-tickrangeUltraplot/UltraPlot:fix-log-formatter-tickrangeCopy head branch name to clipboard
cvanelteren merged 7 commits into
mainUltraplot/UltraPlot:mainfrom
fix-log-formatter-tickrangeUltraplot/UltraPlot:fix-log-formatter-tickrangeCopy head branch name to clipboard
Conversation
Drop unsupported tickrange kwarg for non-UltraPlot formatters and add a regression test for log colorbars.
Retry formatter construction without tickrange on TypeError to avoid crashes for formatters lacking that kwarg.
Drop signature inspection and rely on a TypeError retry without tickrange for maximum compatibility.
beckermr
approved these changes
Jan 26, 2026
Collaborator
Author
|
Need to fix the CI, not sure why it keeps on reporting red while the tests are passing. |
K-Mirembe-Mercy
pushed a commit
to K-Mirembe-Mercy/UltraPlot
that referenced
this pull request
Mar 22, 2026
* Fix log formatter tickrange crash Drop unsupported tickrange kwarg for non-UltraPlot formatters and add a regression test for log colorbars. * Harden formatter tickrange handling Retry formatter construction without tickrange on TypeError to avoid crashes for formatters lacking that kwarg. * Simplify formatter tickrange handling Drop signature inspection and rely on a TypeError retry without tickrange for maximum compatibility. * Add img cmp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the log colorbar formatter crash by filtering out unsupported
tickrangekwargs when constructing Matplotlib formatters, and add a regression test that exercises a log‑norm colorbar withformatter="log".Closes #506