PM Drone Restructure #186
PM Drone Restructure #186nehasriva025 wants to merge 13 commits into
Conversation
* Added a sample pull request template * Add require-checklist github action
…t-SW-ALuo into PM-Restructure
…t-SW-ALuo into PM-Restructure
antholuo
left a comment
There was a problem hiding this comment.
Overall it looks good.
There's a few issues with names starting with leading underscores, I'm not sure how hard it will be to go through and change them but it would be great if it's possible!
|
|
||
|
|
||
| //Data for attitude manager to send to path manager. | ||
| typedef struct AttitudeData{ |
There was a problem hiding this comment.
why doesn't fixed wing have this?
|
|
||
| #ifndef TELEM_PATH_INTERFACE_HPP | ||
| #define TELEM_PATH_INTERFACE_HPP | ||
| #define IS_FIXED_WING FALSE |
There was a problem hiding this comment.
Is there anyway we can change these to const or constexpr? We're trying to move away from using #define directives.
| double lattiude; | ||
| }; | ||
|
|
||
| struct fijo{ |
There was a problem hiding this comment.
can you please put a //FIXME or //TODO stating that these are to be changed for comp season
|
|
||
| #else | ||
|
|
||
| _ModifyFlightPathErrorCode editFlightPath(WaypointManager& cruisingStateManager, fijo * telemetryData, _WaypointManager_Data_In input); |
There was a problem hiding this comment.
I know a lot of this isn't your code, but is it possible to change names to no longer having leading underscores?
| static pathManagerState& getInstance(); | ||
| static WaypointManager takeoffPath; | ||
| static _PathData takeoffPoint; | ||
| static _PathData takeoffPoint; // target |
There was a problem hiding this comment.
same thing with leading underscores here
| class landingStage : public pathManagerState | ||
| { | ||
| public: | ||
| void enter(pathManager* pathMgr) {(void) pathMgr;} |
| /** | ||
| * Structure stores information about the waypoints along our path to the destination and back. Got rid of turn radius | ||
| */ | ||
| struct _PathData { |
There was a problem hiding this comment.
is there a reason we have next + prev as well as lat and lon?
Description
Restructured PM to be able to work with both fixed wing and multi rotor aircraft. Implemented PM functions for drone given fijo struct from CV and TM.
Documentation
Partially complete documentation can be found here: https://uwarg-docs.atlassian.net/wiki/spaces/ZP/pages/2035056654/Drone+PM+Restructure