Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Core/Item: Fix item limit category error by sending proper payload#31920

Open
imstuckbro wants to merge 1 commit into
TrinityCore:3.3.5TrinityCore/TrinityCore:3.3.5from
imstuckbro:itemLimitCategoryimstuckbro/TrinityCore:itemLimitCategoryCopy head branch name to clipboard
Open

Core/Item: Fix item limit category error by sending proper payload#31920
imstuckbro wants to merge 1 commit into
TrinityCore:3.3.5TrinityCore/TrinityCore:3.3.5from
imstuckbro:itemLimitCategoryimstuckbro/TrinityCore:itemLimitCategoryCopy head branch name to clipboard

Conversation

@imstuckbro

Copy link
Copy Markdown
Contributor

Changes proposed:

Issues addressed:

Closes # (insert issue tracker number)

Tests performed:

Does it build, tested in-game, etc.

Known issues and TODO list: (add/remove lines as needed)

  • [ One caveat I see is that the errors for EQUIP_ERR_ITEM_MAX_LIMIT_CATEGORY_COUNT_EXCEEDED_IS seems inversed as follow: Sender sees: "You can only carry 1 Healthstone."
    Receiver sees: "Your trade partner can only accept 1 Healthstone (the item we tested)." ] but I think this is not related.

Co-Authored-By: robinsch <robinsch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.