Add vehicle access equipments#949
Open
Robbendebiene wants to merge 14 commits into
TransmodelEcosystem:v2.0TransmodelEcosystem/NeTEx:v2.0from
OPENER-next:vehicle-access-equipmentsOPENER-next/NeTEx:vehicle-access-equipmentsCopy head branch name to clipboard
Open
Add vehicle access equipments#949Robbendebiene wants to merge 14 commits intoTransmodelEcosystem:v2.0TransmodelEcosystem/NeTEx:v2.0from OPENER-next:vehicle-access-equipmentsOPENER-next/NeTEx:vehicle-access-equipmentsCopy head branch name to clipboard
Robbendebiene wants to merge 14 commits into
TransmodelEcosystem:v2.0TransmodelEcosystem/NeTEx:v2.0from
OPENER-next:vehicle-access-equipmentsOPENER-next/NeTEx:vehicle-access-equipmentsCopy head branch name to clipboard
Conversation
This addresses: - How to model an entrance that has retractable steps complementing built-in steps? What should be NumberOfSteps in this case? (see ICE) - How to detect that something is a sliding step offering level access. It is somehow a step but doesn't introduce any relevant stepping height for passengers.
Only have a single kneeling property that indicates whether other measurements where taken when kneeling is active/inactive.
… the cost of inventing a new term
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #873
In general the proposal follows the idea of place equipments like
LiftEquipmentorRampEquipmentwhich all derive from an abstractAccessEquipment.This slightly deviates from the original proposal in the following ways:
MinimumEquipmentLengthandMaximumEquipmentLengthto avoid choice element in favour ofIsAdjustableLength. Also the minimum length for sliding steps and ramps would usually be close to 0 which isn't very valuable.HoistOperatingRadiustoHoistVehicleEquipmentfor feature parity withAccessVehicleEquipmentNumberOfTreadstoRetractableStepVehicleEquipmentto clarify some scenarios (see aa7c6e3)AccessVehicleEquipment&WheelchairVehicleEquipmentto reusePassengerEquipmentGroupin order to avoid code duplication (see 563fdab)KneelingBoardingHeightin favour of a more flexible modelling way