Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

"check parent branch" check should not block PR against v2.0 #1035

Copy link
Copy link

Description

@thbar
Issue body actions

Taking down notes to document this (ping @ue71603, @TuThoThai, @ptitfred since this has been discussed with you), even if the fix is going to be easy.

The check I introduced in #1022 to avoid end-of-year costly backports is configured to run only for PR targeting either v2.1-wip or v3.0-wip.

on:
pull_request:
branches: [v2.1-wip, v3.0-wip]

This is correct, but as seen in PR targeting branch v2.0 at the moment (e.g. #1030), the status check is verified, but doesn't actually run:

Image

This is caused by the way the ruleset is configured.

I'll share & screenshot & modify it, which will unlock the situation while keeping the check on the correct targets.

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

Morty Proxy This is a proxified and sanitized view of the page, visit original site.