Add an option to prioritize submittedPinTheme over focusedPinTheme#159
Open
AhmedLSayed9 wants to merge 1 commit into
Open
Add an option to prioritize submittedPinTheme over focusedPinTheme#159AhmedLSayed9 wants to merge 1 commit into
AhmedLSayed9 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When all pins are submitted, last pin can be in both submitted & focused state and currently it'll pick
focusedPinTheme.This PR adds an option to pick
submittedPinThemeinstead.This is necessary so when using some custom shape for the non-submitted pins (i.e just an empty circle), the last pinned can be displayed properly when it's pressed.