Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix Network Server field mask usage in the Console#3664

Merged
htdvisser merged 1 commit into
v3.10TheThingsNetwork/lorawan-stack:v3.10from
fix/field-maskTheThingsNetwork/lorawan-stack:fix/field-maskCopy head branch name to clipboard
Jan 14, 2021
Merged

Fix Network Server field mask usage in the Console#3664
htdvisser merged 1 commit into
v3.10TheThingsNetwork/lorawan-stack:v3.10from
fix/field-maskTheThingsNetwork/lorawan-stack:fix/field-maskCopy head branch name to clipboard

Conversation

@adriansmares

@adriansmares adriansmares commented Jan 14, 2021

Copy link
Copy Markdown
Contributor

Summary

References #3421
References #3444

Changes

  • Backport fix to v3.10

Testing

Screen Shot 2021-01-14 at 10 50 38

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added the c/network server This is related to the Network Server label Jan 14, 2021
@adriansmares adriansmares added this to the January 2021 milestone Jan 14, 2021
@adriansmares adriansmares self-assigned this Jan 14, 2021
@adriansmares adriansmares changed the base branch from v3.11 to v3.10 January 14, 2021 08:47
@adriansmares adriansmares changed the title console: Fix Network Server field mask validation Fix Network Server field mask validation in the Console Jan 14, 2021
@github-actions github-actions Bot added the ui/web This is related to a web interface label Jan 14, 2021
@adriansmares adriansmares changed the title Fix Network Server field mask validation in the Console Fix Network Server field mask usage in the Console Jan 14, 2021
@adriansmares adriansmares removed the c/network server This is related to the Network Server label Jan 14, 2021

@kschiffer kschiffer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on staging and works.

@htdvisser htdvisser merged commit edff17f into v3.10 Jan 14, 2021
@htdvisser htdvisser deleted the fix/field-mask branch January 14, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui/web This is related to a web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.