Fix uplink frame counters being limited to 16 bits in Network Server#2876
Merged
rvolosatovs merged 2 commits intoJul 10, 2020
TheThingsNetwork:masterTheThingsNetwork/lorawan-stack:masterfrom
rvolosatovs:fix/fcnt-limitrvolosatovs/lorawan-stack-fork:fix/fcnt-limitCopy head branch name to clipboard
Merged
Fix uplink frame counters being limited to 16 bits in Network Server#2876rvolosatovs merged 2 commits intoTheThingsNetwork:masterTheThingsNetwork/lorawan-stack:masterfrom rvolosatovs:fix/fcnt-limitrvolosatovs/lorawan-stack-fork:fix/fcnt-limitCopy head branch name to clipboard
rvolosatovs merged 2 commits into
TheThingsNetwork:masterTheThingsNetwork/lorawan-stack:masterfrom
rvolosatovs:fix/fcnt-limitrvolosatovs/lorawan-stack-fork:fix/fcnt-limitCopy head branch name to clipboard
Conversation
Contributor
Author
|
changing branch reset all the labels, review requests etc. @johanstokking please review |
htdvisser
approved these changes
Jul 10, 2020
johanstokking
approved these changes
Jul 10, 2020
rvolosatovs
added a commit
to rvolosatovs/lorawan-stack-fork
that referenced
this pull request
Jul 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/TheThingsIndustries/lorawan-stack-support/issues/64?notification_referrer_id=MDE4Ok5vdGlmaWNhdGlvblRocmVhZDk4NDA4MjA5MToxMjg3NzkwNQ%3D%3D#issuecomment-656074683
Changes
MACPayload.FullFCntTesting
unit tests
Regressions
Things that depend on uplink FCnt, e.g. ADR
Checklist
README.md. The target branch is set tomasterif the changes are fully compatible with existing API, database, configuration and CLI.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.