Avoid pushing pre-release builds to Docker hub#229
Merged
rvolosatovs merged 2 commits intoMar 5, 2019
TheThingsNetwork:masterTheThingsNetwork/lorawan-stack:masterfrom
rvolosatovs:fix/228-prerelease-dockerrvolosatovs/lorawan-stack-fork:fix/228-prerelease-dockerCopy head branch name to clipboard
Merged
Avoid pushing pre-release builds to Docker hub#229rvolosatovs merged 2 commits intoTheThingsNetwork:masterTheThingsNetwork/lorawan-stack:masterfrom rvolosatovs:fix/228-prerelease-dockerrvolosatovs/lorawan-stack-fork:fix/228-prerelease-dockerCopy head branch name to clipboard
rvolosatovs merged 2 commits into
TheThingsNetwork:masterTheThingsNetwork/lorawan-stack:masterfrom
rvolosatovs:fix/228-prerelease-dockerrvolosatovs/lorawan-stack-fork:fix/228-prerelease-dockerCopy head branch name to clipboard
Conversation
johanstokking
approved these changes
Mar 5, 2019
johanstokking
left a comment
Member
There was a problem hiding this comment.
Please file a technical debt issue, because I'm against a permanent fork of goreleaser.
The issue is either that we don't publish pre-releases at all (and only tag) and/or use an updated goreleaser that supports this feature / has this patch integrated.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #228
Changes:
goreleaseruntil ability to skip Docker update for pre-releases (#977) goreleaser/goreleaser#978 is merged