fix: fixed mock file system exception when using root path as a parameter - #1132
#1132fix: fixed mock file system exception when using root path as a parameter#1132vbreuss merged 9 commits intoTestableIO:mainTestableIO/System.IO.Abstractions:mainfrom vladimir-shirmanov:bugfix/support-different-rootsvladimir-shirmanov/System.IO.Abstractions:bugfix/support-different-rootsCopy head branch name to clipboard
Conversation
vbreuss
left a comment
There was a problem hiding this comment.
Thanks for the pull request, I only have some minor suggestions.
Please also adapt the title to conform to the conventional commits guideline.
oh sure, I'll add those in future commits. |
vbreuss
left a comment
There was a problem hiding this comment.
Looks good, thank you for your effort, @vladimir-shirmanov 👍
vbreuss
left a comment
There was a problem hiding this comment.
Sorry, I just saw, that the tests failed for Ubuntu and MacOS. Probably the path separator must be OS dependent, @vladimir-shirmanov
I see that some tests are marked as Windows only, how do you think is it a good candidate for that as well? |
|
This is addressed in release v21.0.26. |
fix: MockFileSystem does not support Root directories
Description
Added a check inside AddFile to be able to add new Drives within a constructor
Fixed #702