Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: use correct path for wrapped FileInfo and DirectoryInfo - #1079

#1079
Merged
mergify[bot] merged 2 commits into
TestableIO:mainTestableIO/System.IO.Abstractions:mainfrom
vbreuss:topic/fix-path-of-wrapped-directory-infovbreuss/System.IO.Abstractions:topic/fix-path-of-wrapped-directory-infoCopy head branch name to clipboard
Jan 22, 2024
Merged

fix: use correct path for wrapped FileInfo and DirectoryInfo#1079
mergify[bot] merged 2 commits into
TestableIO:mainTestableIO/System.IO.Abstractions:mainfrom
vbreuss:topic/fix-path-of-wrapped-directory-infovbreuss/System.IO.Abstractions:topic/fix-path-of-wrapped-directory-infoCopy head branch name to clipboard

Conversation

@vbreuss

@vbreuss vbreuss commented Jan 22, 2024

Copy link
Copy Markdown
Member

Use the full path when wrapping a FileInfo or DirectoryInfo to preserve the relevant information.

Fixes #1049

@fgreinacher fgreinacher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vbreuss, LGTM!

@mergify
mergify Bot merged commit 3d517f4 into TestableIO:main Jan 22, 2024
@github-actions

Copy link
Copy Markdown

This is addressed in release v20.0.15.

@github-actions github-actions Bot added the state: released Issues that are released label Jan 22, 2024
@vbreuss
vbreuss deleted the topic/fix-path-of-wrapped-directory-info branch January 22, 2024 10:08
mergify Bot referenced this pull request in Testably/Testably.Abstractions Jan 22, 2024
…20.0.15 (#451)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions)
| `20.0.4` -> `20.0.15` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/TestableIO.System.IO.Abstractions/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/TestableIO.System.IO.Abstractions/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/TestableIO.System.IO.Abstractions/20.0.4/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/TestableIO.System.IO.Abstractions/20.0.4/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>TestableIO/System.IO.Abstractions
(TestableIO.System.IO.Abstractions)</summary>

###
[`v20.0.15`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v20.0.15)

#### What's Changed

- chore(deps): update dependency benchmarkdotnet to v0.13.11 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1066](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1066)
- refactor: Convert Classic Assert to Constraint Model by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1065](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1065)
- chore(deps): update actions/upload-artifact action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1068](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1068)
- chore(deps): update actions/download-artifact action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1067](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1067)
- chore(deps): update dependency saucecontrol.inheritdoc to v2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1069](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1069)
- chore(deps): update apexskier/github-release-commenter action to
v1.3.6 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1071](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1071)
- chore(deps): update dependency benchmarkdotnet to v0.13.12 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1075](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1075)
- chore(deps): update dependency nunit to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1058](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1058)
- chore(deps): update dependency dotnet-sdk to v8.0.101 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1077](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1077)
- refactor: remove workaround for Snapshooter/NUnit 4/.NET 4.6.2 compat…
by [@&#8203;fgreinacher](https://togithub.com/fgreinacher) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1076](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1076)
- fix: use correct path for wrapped `FileInfo` and `DirectoryInfo` by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1079](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1079)

**Full Changelog**:
TestableIO/System.IO.Abstractions@v20.0.4...v20.0.15

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state: released Issues that are released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IDirectoryInfoFactory.Wrap loses part of absolute path when used with MockFileSystem

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.