DLSV2-581-error-in-sumiting-without-supervisor-and-date-issue - #1434
#1434Merged
kevwhitt-hee merged 5 commits intoOct 18, 2022
masterTechnologyEnhancedLearning/DLSV2:masterfrom
DLSV2-581-error-in-sumiting-without-supervisorTechnologyEnhancedLearning/DLSV2:DLSV2-581-error-in-sumiting-without-supervisorCopy head branch name to clipboard
Merged
DLSV2-581-error-in-sumiting-without-supervisor-and-date-issue#1434kevwhitt-hee merged 5 commits intomasterTechnologyEnhancedLearning/DLSV2:masterfrom DLSV2-581-error-in-sumiting-without-supervisorTechnologyEnhancedLearning/DLSV2:DLSV2-581-error-in-sumiting-without-supervisorCopy head branch name to clipboard
kevwhitt-hee merged 5 commits into
masterTechnologyEnhancedLearning/DLSV2:masterfrom
DLSV2-581-error-in-sumiting-without-supervisorTechnologyEnhancedLearning/DLSV2:DLSV2-581-error-in-sumiting-without-supervisorCopy head branch name to clipboard
Conversation
kevwhitt-hee
requested changes
Oct 18, 2022
kevwhitt-hee
left a comment
Contributor
There was a problem hiding this comment.
This fixes issues with enrolling on without selecting a supervisor but I've suggested a couple of tiny tweaks in code.
It would be good to fix the validation error Seema has spotted (we should get rid of the error message that has a typo in it rather than fixing the typo, I think) before releasing.
Almost there!
| DateTime startedDate = DateTime.Now; | ||
| DateTime lastAccessed = startedDate; | ||
| string completedDate = ""; | ||
| dynamic completedDate = ""; |
Contributor
There was a problem hiding this comment.
This variable should be named completeByDateDynamic rather than completedDate to ensure it has accurate meaning.
Contributor
Author
There was a problem hiding this comment.
changes has been done
kevwhitt-hee
left a comment
Contributor
There was a problem hiding this comment.
These look good. If we could fix the validation message issues spotted by Seema, that would be good.
Remove blank line in using statements
kevwhitt-hee
approved these changes
Oct 18, 2022
kevwhitt-hee
deleted the
DLSV2-581-error-in-sumiting-without-supervisor
branch
October 18, 2022 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-581
Description
fixed issues during submission for date and supervisor id
Screenshots
no screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: