DLSV2-581 Enrol delegate on activity from All Delegates view - #1409
#1409Merged
Merged
DLSV2-581 Enrol delegate on activity from All Delegates view#1409
Conversation
kevwhitt-hee
requested changes
Sep 30, 2022
kevwhitt-hee
left a comment
Contributor
There was a problem hiding this comment.
Please add the Migration to update the SP (see comment in code).
kevwhitt-hee
requested changes
Oct 5, 2022
kevwhitt-hee
left a comment
Contributor
There was a problem hiding this comment.
This is looking pretty good, Manish. A few changes suggested in code. Mainly swapping markup for form items for the prebuilt ViewComponents in the project.
kevwhitt-hee
approved these changes
Oct 14, 2022
kevwhitt-hee
left a comment
Contributor
There was a problem hiding this comment.
This looks amazing, now. Great work, Manish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-581
Description
There is a button in the expanded view of a delegate on the All Delegates page labelled “Enrol on course”. This button launches a modal popup allowing the user to select the course, then choose supervisor, complete by date and review the learning pathway defaults for the course.
Screenshots
The screenshots can be found at https://hee-dls.atlassian.net/browse/DLSV2-581
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: