Adding support for Column changes on Tasks#45
Merged
Adding support for Column changes on Tasks#45
Conversation
Flexicon
approved these changes
Aug 9, 2021
Contributor
Flexicon
left a comment
There was a problem hiding this comment.
LGTM 👍 seems to run fine locally too
1001hz
reviewed
Aug 9, 2021
| log::message "Task found with the id: $task_id" | ||
|
|
||
| export TEAMWORK_TASK_ID=$task_id | ||
| local -r project_id="$(teamwork::get_project_id_from_task "$task_id")" |
There was a problem hiding this comment.
Hey @rkreutz our deskclient builds are failing now with the error saying /src/main.sh: line 45: local: project_id: readonly variable.
https://github.com/Teamwork/deskclient/pull/4845/checks?check_run_id=3280181461
Contributor
Author
There was a problem hiding this comment.
I guess removing that -r will fix it, will open a new PR for that
Contributor
Author
There was a problem hiding this comment.
Actually just removing the quotes should do, gonna try adding this to the tests to confirm
Contributor
There was a problem hiding this comment.
It only fails for task descriptions that have more than 1 TW task link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
This PR adds the capability to move tasks across Columns in Project during the different stages of a PR.
How
I'm introducing three new inputs:
BOARD_COLUMN_OPENED,BOARD_COLUMN_MERGEDandBOARD_COLUMN_CLOSED. The tasks would be moved to the specified columns as the PR is opened, merged or closed (respectively).On our workflow this would be extremely helpful, since we use the Board view in Teamwork to visually see what's the status on each task, we would start the task by moving it to "In Development", then once a PR is open we move it to "Has PR" and finally once the PR is merged the task is ready to be tested and moved to "Nightly". Optionally we may move the task back to "Selected For Development" in case the PR was rejected and closed.