Content and Lookup Management API Additions#62
Merged
himanshu219 merged 2 commits intoJun 18, 2020
SumoLogic:masterSumoLogic/sumologic-python-sdk:masterfrom
produceallthethings:content-and-lookup-management-apisproduceallthethings/sumologic-python-sdk:content-and-lookup-management-apisCopy head branch name to clipboard
Merged
Content and Lookup Management API Additions#62himanshu219 merged 2 commits intoSumoLogic:masterSumoLogic/sumologic-python-sdk:masterfrom produceallthethings:content-and-lookup-management-apisproduceallthethings/sumologic-python-sdk:content-and-lookup-management-apisCopy head branch name to clipboard
himanshu219 merged 2 commits into
SumoLogic:masterSumoLogic/sumologic-python-sdk:masterfrom
produceallthethings:content-and-lookup-management-apisproduceallthethings/sumologic-python-sdk:content-and-lookup-management-apisCopy head branch name to clipboard
Conversation
Various commands associated to the Content and Lookup management APIs have been incorporated
himanshu219
approved these changes
Jun 17, 2020
Contributor
There was a problem hiding this comment.
LGTM(apart from the nit) this is more comprehensive than PR will close out other one.
| return self.get('/apps/install/%s/status' % job_id) | ||
|
|
||
| def export_content(self, content_id): | ||
| return self.post('/content/%s/export' % content_id, params=content_id, version='v2') |
Contributor
There was a problem hiding this comment.
do we need params also? I think it should work with params="" as well.
Contributor
Author
There was a problem hiding this comment.
Good spotting, you're correct with leaving them blank. I've committed the change
Params have been updated to "" instead of content_id
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various commands associated to the Content and Lookup management APIs have been added