Prevent invalid SQL detection when keyword is part of something else#2
Open
Jenselme wants to merge 4 commits into
Submersible:mainSubmersible/better-python-string-sql:mainfrom
Jenselme:fix-wrong-detectionJenselme/better-python-strings:fix-wrong-detectionCopy head branch name to clipboard
Open
Prevent invalid SQL detection when keyword is part of something else#2Jenselme wants to merge 4 commits intoSubmersible:mainSubmersible/better-python-string-sql:mainfrom Jenselme:fix-wrong-detectionJenselme/better-python-strings:fix-wrong-detectionCopy head branch name to clipboard
Jenselme wants to merge 4 commits into
Submersible:mainSubmersible/better-python-string-sql:mainfrom
Jenselme:fix-wrong-detectionJenselme/better-python-strings:fix-wrong-detectionCopy head branch name to clipboard
Conversation
This could happen for instance when a string contained attachedField: attach was incorrectly detected as the start of some SQL. This resulted in a random word being highlighted and the Python syntax highlighting to be messed up.
|
This single quote part of regex causes improper highlighting of parentheses when 'somestring' is used inside """ """ code: WITH the single quote option: |
|
I forked the project to improve on the thing as well as in Python print() https://github.com/RadoslawDeska/better-python-string-sql-refined/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could happen for instance when a string contained attachedField: attach was incorrectly detected as the start of some SQL. This resulted in a random word being highlighted and the Python syntax highlighting to be messed up.