Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5e15c38

Browse filesBrowse files
committed
Revert "Revert "Disable HTTP Nowhere menu item when HTTPS Everywhere is disabled""
This reverts commit 27119a1.
1 parent 40aedfe commit 5e15c38
Copy full SHA for 5e15c38

1 file changed

+10-1Lines changed: 10 additions & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/chrome/content/toolbar_button.js‎

Copy file name to clipboardExpand all lines: src/chrome/content/toolbar_button.js
+10-1Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ httpsEverywhere.toolbarButton = {
7373
httpNowhereItem.setAttribute('checked', showHttpNowhere ? 'true' : 'false');
7474
toolbarbutton.setAttribute('http_nowhere',
7575
showHttpNowhere ? 'true' : 'false');
76+
var enabled = HTTPSEverywhere.prefs.getBoolPref("globalEnabled");
77+
httpNowhereItem.setAttribute('disabled', enabled ? 'false' : 'true');
7678

7779
// show ruleset counter when a tab is changed
7880
tb.updateRulesetsApplied();
@@ -228,9 +230,11 @@ httpsEverywhere.toolbarButton = {
228230
* Toggles whether HTTP Nowhere mode is active, updates the toolbar icon.
229231
*/
230232
toggleHttpNowhere: function() {
231-
var tb = httpsEverywhere.toolbarButton;
232233
HTTPSEverywhere.toggleHttpNowhere();
234+
var tb = httpsEverywhere.toolbarButton;
233235
var showHttpNowhere = tb.shouldShowHttpNowhere();
236+
237+
// Change icon color to red if HTTP nowhere is enabled
234238
var toolbarbutton = document.getElementById('https-everywhere-button');
235239
toolbarbutton.setAttribute('http_nowhere',
236240
showHttpNowhere ? 'true' : 'false');
@@ -353,6 +357,11 @@ function toggleEnabledState(){
353357
HTTPSEverywhere.toggleEnabledState();
354358
reload_window();
355359

360+
// Disable/enable toggling HTTP Nowhere mode
361+
var httpNowhereItem = document.getElementById('http-nowhere-item');
362+
var enabled = HTTPSEverywhere.prefs.getBoolPref("globalEnabled");
363+
httpNowhereItem.setAttribute('disabled', enabled ? 'false' : 'true');
364+
356365
// Change icon depending on enabled state
357366
httpsEverywhere.toolbarButton.changeIcon();
358367
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.